-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.p: cameraThe camera pluginThe camera pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team
Description
As the android_camera_camerax plugin has been under development, there have a number of tasks that have not blocked PRs but are important technical debt to pay down. This umbrella issue covers those tasks that apply to cleaning up tests in this plugin:
- Consider implementing a
setUp()method for the plugin Dart test since several of the same setup steps are involved. - Consider refactoring the
FakeAndroidCameraCameraXclassed used in the plugin Dart test for testing, since it is likely these objects used in the test can be mocked without using it. #138633 - Condense test mock files that contain same mocks, namely mocks for
TestInstanceManagerHostApi. - Reduce assertion calls in tests that loop over various types (example)
- Add test for behavior of using weak references of plugin implementation in callback methods to avoid memory leaks (see discussion).
- Reduce parameters that are not necessary to be visible for testing (now that I've added a proxy, some of these can be private).
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.p: cameraThe camera pluginThe camera pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team
Type
Projects
Status
To do