Skip to content

[camerax] ☂️ Clean up wrapped native classes #125926

@camsim99

Description

@camsim99

As the android_camera_camerax plugin has been under development, there have a number of tasks that have not blocked PRs but are important technical debt to pay down. This umbrella issue covers those tasks that apply to refactoring wrapped native classes:

  • Refactor logic in constructors/create methods to helper methods or to callers of those methods.
  • Remove any redundant documentation added or left by the autogenerator.
  • [Dart-specific] Make Dart Host API implementations private.
  • There are currently two ways to create files to save recordings to; condense to one.
  • [Native-specific] Move checks for objects being managed by an InstanceManager to the Flutter API implementations themselves versus where instances of those implementations are used.
  • Use command pattern to use handlers to create objects of each type that is represented by a LiveDataSupportedType (see original comment).

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityc: tech-debtTechnical debt, code quality, testing, etc.p: cameraThe camera pluginpackageflutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions