Skip to content

Revert migration of mac host engine to engine v2 #124911

@godofredoc

Description

@godofredoc

flutter/engine#41233

Some notes for a triaging chat:

It looks like somehow the framework is using an ancient engine version.

I flutter create a brand new project and run it with flutter run -d mac and I get:
Building macOS application...
2023-04-14 19:09:24.908 deleteme[83098:3926602] NSApp should be of type FlutterApplication, not NSApplication.
System requests for the application to terminate will not be sent to the Flutter framework, so the framework will be unable to cancel those requests.
Modify the application's NSPrincipleClass to be FlutterApplication in the Info.plist to fix this.
[ERROR:flutter/shell/common/shell.cc(89)] Dart Error: Can't load Kernel binary: Invalid SDK hash.
[ERROR:flutter/runtime/dart_isolate.cc(144)] Could not prepare isolate.
[ERROR:flutter/runtime/runtime_controller.cc(422)] Could not create root isolate.
[ERROR:flutter/shell/common/shell.cc(606)] Could not launch engine with configuration.
First off the kernel hash is mismatched which indicates something's way off between the engine and framework and second, the "NSApp should be of type FlutterApplication, not NSApplication." was removed over a week ago in https://github.com/flutter/engine/pull/40929, before the branch.

The framework claims to be using an engine.verison of 0a5ed019cea52f4134cc731925d540bb0a0cb5b4 which is definitely pretty close to tip of tree and definitely doesn't have the error message code listed above...
% cat bin/internal/engine.version
0a5ed019cea52f4134cc731925d540bb0a0cb5b4
% grep -r "NSApp should be of type" bin/cache/artifacts/engine/darwin-x64/FlutterMacOS.framework
Binary file bin/cache/artifacts/engine/darwin-x64/FlutterMacOS.framework/Versions/A/FlutterMacOS matches
% git reset --hard 0a5ed019cea52f4134cc731925d540bb0a0cb5b4
HEAD is now at 0a5ed019ce Roll Skia from 22e417bea884 to f489b4a06e19 (6 revisions) (#41225)
% git grep "NSApp should be of type"
%
% git bisect good
016bcc10001e675948534efa4ab568d3e2df85fd is the first bad commit
commit 016bcc10001e675948534efa4ab568d3e2df85fd
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Apr 14 21:21:26 2023 -0400

    Roll Flutter Engine from f7945293aced to 0a5ed019cea5 (2 revisions) (#124901)

    https://github.com/flutter/engine/compare/f7945293aced...0a5ed019cea5

    2023-04-14 [email protected] Roll Skia from 22e417bea884 to f489b4a06e19 (6 revisions) (flutter/engine#41225)
    2023-04-14 [email protected] Roll Dart SDK from 36b37d0a8db7 to 5687f08b854d (1 revision) (flutter/engine#41224)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.

    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

 bin/internal/engine.version | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Metadata

Metadata

Assignees

Labels

team-infraOwned by Infrastructure team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions