Skip to content

Engine android CI should verify VisibleForTests field are not used #124890

@CaseyHillers

Description

@CaseyHillers

We had to send a revert in flutter/engine#41211 as this failed analysis checks on Google Testing, but not the LUCI checks.

shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java:239: Error: This method should only be accessed from tests or within private scope [VisibleForTests]
      imeSyncCallback.remove();

My expectation is analysis checks like this should be caught in presubmit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.platform-androidAndroid applications specificallyteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions