Skip to content

[Impeller] ToColor converts an SkColor instead of a DlColor. #124455

@flar

Description

@flar

It likely doesn't matter, but the DisplayList should only contain DlColor objects yet the ToColor converter in Impeller takes an SkColor as an argument. It turns out these two types can be implicitly converted between each other with no work, but the ToColor method should probably be declared to take a DlColor (and a search done to make sure that there are no instances of SkColor left that it needs to convert).

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions