-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsf: integration_testThe flutter/packages/integration_test pluginThe flutter/packages/integration_test pluginframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
The integration_test package has various deprecations, but it's troublesome to follow through with the deprecations and remove things when no dart fix is available to guide users through the migration.
Add dart fix capabilities to integration_test following the flutter example found in the packages/flutter/lib/fix_data folder.
Fixes
- A new "fix_data" folder will be added under the "integration_test/lib" folder
- Fixes under "fix_data" will be in a folder structure mirroring the lib folder, but with "fix_" prefixes on the folder names
- Library level fixes will be directly under the "fix_data" folder, named "fix_<library_name>.yaml"
- Individual files will be made for each class that requires fixes, named "fix_<class_name>.yaml"
- This may mean that a single code file will have multiple files for fixes.
Testing fixes
- Fixes will be required to be tested
- Tests will be under a new "test_fixes" folder
- The folder/file structure will mirror the "fix_data" folder, without the "fix_" prefixes
- Each file in "fix_data" will have a matching set of two files in "test_fixes" named "<library_name|class_name>.dart" and "<library_name|class_name>.dart.expect" where the ".dart" file is the pre-fix code and ".dart.expect" is the post-fix expectation.
- These tests will be run alongside the existing flutter fix tests by updating
dev/bots/test.dart#_runFrameworkTests.runSlowto also run fix tests for theintegration_testpackage
bartekpacia and gnprice
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsf: integration_testThe flutter/packages/integration_test pluginThe flutter/packages/integration_test pluginframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.