Skip to content

[Impeller] Flaky impeller golden test in the engine #124277

@Piinks

Description

@Piinks

After flutter/engine#40824, there appears to be a flaky golden file test in the engine that is blocking other PRs from landing (example: flutter/engine#40924).

Screenshot 2023-04-05 at 4 48 25 PM

The individual dots to the right show different colors, meaning a unique image was generated for each commit.
This is with the fuzzy matching algorithm set for this test:

Screenshot 2023-04-05 at 4 51 07 PM

Also, it looks like this image is even flaking in post submit, because the same test is listed as untriaged on the main branch: https://flutter-engine-gold.skia.org/

In the framework we have the tree go red if an unapproved image shows up in post submit, maybe the engine implementation should do the same.

cc @mdebbar @dnfield @chinmaygarde @gaaclarke

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: flakeTests that sometimes, but not always, incorrectly passe: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team: presubmit flakesPresubmit flakes found

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions