-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passe: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team: presubmit flakesPresubmit flakes foundPresubmit flakes found
Description
After flutter/engine#40824, there appears to be a flaky golden file test in the engine that is blocking other PRs from landing (example: flutter/engine#40924).
The individual dots to the right show different colors, meaning a unique image was generated for each commit.
This is with the fuzzy matching algorithm set for this test:
Also, it looks like this image is even flaking in post submit, because the same test is listed as untriaged on the main branch: https://flutter-engine-gold.skia.org/
In the framework we have the tree go red if an unapproved image shows up in post submit, maybe the engine implementation should do the same.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passe: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team: presubmit flakesPresubmit flakes foundPresubmit flakes found

