Skip to content

Prefer command line settings to plist/androidmanifest settings #124049

@dnfield

Description

@dnfield

Right now the engine prefers some settings to the value in Info.plist even if the command line specifies a different value. This is almost certainly unexpected for developers manually specifying command line arguments.

We should change the code here https://github.com/flutter/engine/blob/95a962fea38bb27cba07edadb525857d1f712ae9/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm#L99 so that the settings are read from the command line after the plist is parsed. Unfortunately, the settings for Android are handled in a few different spots and will have to be audited differently. We also have to audit whether the tool is ever specifying a setting explicitly with the default value or not.

For now, I am changing the behavior of this for enable-impeller to try to get it in for the next stable without too much disruption.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.platform-androidAndroid applications specificallyplatform-iosiOS applications specificallyteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions