-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)c: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
These two classes should be an enum, because they work as enum, but they are older than the enhanced enum, so this wasn't possible before. Now it is.
We can remove 200 LOC of these classes and make them as similar as they can be to enums. Enum has its own index, so it clashes with the index from them and would be a super breaking change because affects Google Testing. But changing everything else and cleanup isn't.
This is kind of breaking because Flutter uses semanticsFlag.values.values, but I searched on code search and couldn't find a repo that uses that (besides code-gen), so it seems really internal.
- part 1: [engine] add
valuesAsList(SemanticsFlag/SemanticsActioncleanup (part 1) engine#40571) - part 2: [flutter] use
valuesAsList(SemanticsFlag/SemanticsActioncleanup (part 2) #123817) - part 3: [engine]
convert to enumcleanup (SemanticsFlag/SemanticsActioncleanup (part 3) engine#40567) - part 4: [flutter] use
valuesagain (SemanticsFlag/SemanticsActioncleanup (part 4) #123329) - part 5: [engine] remove
valuesAsList(SemanticsAction/SemanticsFlagcleanup part 5 engine#41126) - part 6: [flutter] deprecate
describeEnum(DeprecatedescribeEnum. #125016)
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)c: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team