Skip to content

☂️ Cleanup SemanticsFlag and SemanticsAction.  #123346

@bernaferrari

Description

@bernaferrari

These two classes should be an enum, because they work as enum, but they are older than the enhanced enum, so this wasn't possible before. Now it is.

We can remove 200 LOC of these classes and make them as similar as they can be to enums. Enum has its own index, so it clashes with the index from them and would be a super breaking change because affects Google Testing. But changing everything else and cleanup isn't.

This is kind of breaking because Flutter uses semanticsFlag.values.values, but I searched on code search and couldn't find a repo that uses that (besides code-gen), so it seems really internal.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)c: proposalA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions