-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/packages
#5420Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterp: plugin_platform_interfacePlugin platform infrastructurePlugin platform infrastructurepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team
Description
Use case
When writing Plugin tests, MockPlatformInterfaceMixin is provided to be able to mock PlatformInterface.
However, MockPlatformInterfaceMixin is defined as a class, which conflicts with linter rule prefer_mixin (https://dart-lang.github.io/linter/lints/prefer_mixin.html)
Proposal
Change MockPlatformInterfaceMixin from class to mixin
mixin MockPlatformInterfaceMixin implements PlatformInterface {}
oprypin
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterp: plugin_platform_interfacePlugin platform infrastructurePlugin platform infrastructurepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team