Skip to content

Engine -> Framework roll stopped on framework text field test failures #122950

Closed

Description

@zanderso

The engine roll here #122942 was reverted due to failures on framework CI here https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20framework_tests_libraries/10172/overview, which has many failures of tests in flutter/packages/flutter/test/material/text_field_test.dart.

Flagging folks with engine commits in that range that seem text related: @flar @LongCatIsLooong @loic-sharma and @jason-simmons to take a look at the Skia rolls to see if there's anything suspicious in them.

Activity

  1. added
    engineflutter/engine related. See also e: labels.
    P0Critical issues such as a build break or regression
    on Mar 18, 2023
  2. flar commented on Mar 18, 2023

    @flar
    Contributor

    Some of the failures are due to properties on Widgets which would not be a result of anything in Skia or any rendering changes. I'd strongly suspect the changes that affected the way accessibility is handled (single root assumption perhaps?)

  3. jason-simmons commented on Mar 18, 2023

    @jason-simmons
    Contributor

    This failure was caused by ordering dependencies in the material/text_field_test.dart tests and does not appear to be related to the engine roll.

    The tests started failing when the daily test order changed to --test-randomize-ordering-seed=20230318.

    The tests run successfully with the #122942 roll and yesterday's seed value (--test-randomize-ordering-seed=20230317)

  4. jason-simmons commented on Mar 18, 2023

    @jason-simmons
    Contributor

    These tests depend on execution order due to the interaction between debugDefaultTargetPlatformOverride and the Theme._kFallbackTheme singleton.

    _kFallbackTheme is a lazily initialized static ThemeData. The fallback theme does not explicitly specify a platform, so the ThemeData constructor sets its platform based on the current value of defaultTargetPlatform.

    Some of the tests in material/text_field_test.dart use TargetPlatformVariant to temporarily override the target platform. So the platform of the fallback theme will depend on which override was in effect the first time _kFallbackTheme was accessed and initialized.

    Later tests may depend on platform-specific behaviors (for example, tests of haptics assume they are running on a platform that enables haptics). These tests will fail if they use the fallback theme and it is bound to an unexpected platform.

    @Hixie @goderbauer What is the best way to fix this?

    Is there a way for the test infrastructure to ensure that _kFallbackTheme is initialized for the Android platform, which is specified as the default for the test environment?

    Or do tests need to avoid instantiating anything that would depend on the fallback theme?

  5. zanderso commented on Mar 18, 2023

    @zanderso
    MemberAuthor

    #122956 <- disables shuffling for this file.

  6. goderbauer commented on Mar 20, 2023

    @goderbauer
    Member

    FYI @pdblasi-google The no-shuffle was recently removed in #122643 from this test.

  7. goderbauer commented on Mar 20, 2023

    @goderbauer
    Member

    I am going to close this as a duplicate of #85160 where we track all tests that need their no-shuffle removed.

  8. github-actions commented on Apr 3, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. locked as resolved and limited conversation to collaborators on Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressionengineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions