macOS text selection toolbar is outdated #121827
Description
The current look-and-feel of the CupertinoDesktopTextSelectionToolbar is outdated and it doesn't change the text color when hovered, which usually leads to poor contrast (see first image).
I already changed all this and will be creating a PR shortly, but I didn't know that it was necessary to have an issue assigned so I'm creating one now. Also, I don't know if I selected the correct template for the issue, but it says "or something looks wrong" on the description, so I'm guessing that this is the right one.
Current flutter context menu:
Flutter context menu with my changes:
Native context menu on macOS 13.2 for reference:
flutter doctor -v
[!] Flutter (Channel master, 3.9.0-1.0.pre.22, on macOS 13.2 22D49 darwin-x64, locale en-BR)
• Flutter version 3.9.0-1.0.pre.22 on channel master at /Users/luccas/Documents/VSCode/flutter
! Warning: `flutter` on your path resolves to /usr/local/Caskroom/flutter/3.0.5/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/luccas/Documents/VSCode/flutter.
Consider adding /Users/luccas/Documents/VSCode/flutter/bin to the front of your path.
! Warning: `dart` on your path resolves to /usr/local/Caskroom/flutter/3.0.5/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/luccas/Documents/VSCode/flutter. Consider
adding /Users/luccas/Documents/VSCode/flutter/bin to the front of your path.
• Upstream repository https://github.com/luccasclezar/flutter.git
• FLUTTER_GIT_URL = https://github.com/luccasclezar/flutter.git
• Framework revision 2f4ca58455 (53 minutes ago), 2023-03-02 17:29:18 -0300
• Engine revision 2849704642
• Dart version 3.0.0 (build 3.0.0-287.0.dev)
• DevTools version 2.22.2
• If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
• Android SDK at /Users/luccas/Library/Developer/Xamarin/android-sdk-macosx
• Platform android-33, build-tools 33.0.1
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14C18
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
[✓] VS Code (version 1.76.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.60.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-x64 • macOS 13.2 22D49 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 110.0.5481.177
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.
Metadata
Metadata
Assignees
Labels
Matching the OEM platforms betterEntering text in a text field or keyboard related problemsflutter/packages/flutter/cupertino repositoryFound to occur in 3.7Found to occur in 3.8flutter/packages/flutter repository. See also f: labels.The issue has been confirmed reproducible and is ready to work onBuilding on or for macOS specificallyIssue is closed as already fixed in a newer version