TextField doesn't properly create a new TextEditingController on didUpdateWidget #12153
Description
In TextEditingController's didUpdateWidget method:
@override
void didUpdateWidget(TextField oldWidget) {
super.didUpdateWidget(oldWidget);
if (widget.controller == null && oldWidget.controller != null)
_controller == new TextEditingController.fromValue(oldWidget.controller.value);
else if (widget.controller != null && oldWidget.controller == null)
_controller = null;
}When widget.controller is null and oldWidget.controller isn't, _controller gets assigned instead of copied. Specifically, this:
_controller == new TextEditingController.fromValue(oldWidget.controller.value);should be
_controller = new TextEditingController.fromValue(oldWidget.controller.value);