-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/packages
#3231Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: go_routerThe go_router packageThe go_router packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version
Description
Steps to Reproduce
In the README.md of go_router_builder, the example is wrong for the default values section:
It is
class MyRoute extends GoRouteData {
MyRoute({this.queryParameter = 'defaultValue'});
final String from;
@override
Widget build(BuildContext context, GoRouterState state) => MyScreen(from: from);
}But it should be
class MyRoute extends GoRouteData {
MyRoute({this.queryParameter = 'defaultValue'});
final String queryParameter;
@override
Widget build(BuildContext context, GoRouterState state) => MyScreen(queryParameter: queryParameter);
}It was introduced in flutter/packages#2826
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: go_routerThe go_router packageThe go_router packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version