NeverScrollableScrollPhysics doesn't work for Scrollable inside DraggableScrollableSheet in 3.7.3 #121021
Description
Steps to Reproduce
For Android:
- Execute
flutter runon the code sample - Try to scroll the list.
- On 3.3.10 it will NOT scroll, on 3.7.3 it will scroll.
Expected results:
Expected it to not be movable by scrolling gestures as in previous version of Flutter.
Actual results:
It actually scrolls, which may break UI/UX in certain cases (when the app expects the sheet to be scrolled via controller).
For Web:
Seems like on web it works correctly.
Code sample
import 'package:flutter/material.dart';
void main() {
runApp(App());
}
class App extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: Stack(
children: [
DraggableScrollableSheet(
maxChildSize: 1,
builder: (context, scrollController) => SingleChildScrollView(
physics: const NeverScrollableScrollPhysics(),
controller: scrollController,
child: Column(
children: List.generate(
200,
(index) => Text(index.toString()),
),
),
),
),
],
),
),
);
}
}Flutter Doctor
[✓] Flutter (Channel stable, 3.7.3, on macOS 12.4 21F79 darwin-x64, locale en-IL)
• Flutter version 3.7.3 on channel stable at /Users/andrey/development/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 9944297138 (9 days ago), 2023-02-08 15:46:04 -0800
• Engine revision 248290d6d5
• Dart version 2.19.2
• DevTools version 2.20.1
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
• Android SDK at /Users/andrey/Library/Android/sdk
• Platform android-33, build-tools 33.0.0
• Java binary at: /Users/andrey/Library/Java/JavaVirtualMachines/corretto-11.0.17/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment Corretto-11.0.17.8.1 (build 11.0.17+8-LTS)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 13F100
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio (version 2022.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
✗ Unable to find bundled Java version.
• Try updating or re-installing Android Studio.
[✓] IntelliJ IDEA Ultimate Edition (version 2022.3.1)
• IntelliJ at /Applications/IntelliJ IDEA.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] Connected device (3 available)
• sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64 • Android 13 (API 33) (emulator)
• macOS (desktop) • macos • darwin-x64 • macOS 12.4 21F79 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 109.0.5414.119
[✓] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 1 category.
Metadata
Metadata
Assignees
Labels
Important issues not at the top of the work listIt was better in the past than it is nowViewports, list views, slivers, etc.Found to occur in 3.7Found to occur in 3.8flutter/packages/flutter repository. See also f: labels.The issue has been confirmed reproducible and is ready to work onIssue is closed as already fixed in a newer version