-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressiona: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsdependency: dartDart team may need to help usDart team may need to help us
Description
Rolls from Engine -> Framework have been failing on customer tests coming from https://github.com/rrousselGit/provider.git. See failure here: https://cirrus-ci.com/task/6685374529929216?logs=main#L1826
This is due to changes in the dart sdk that have upgraded some info diagnostics to warning diagnostics: https://dart-review.googlesource.com/c/sdk/+/283400
We need to do the following:
- Revert the dart SDK rolls to unblock the engine -> framework roll
- Revert the analzyer change so that subsequent dart sdk -> engine rolls don't break downstream
- Fix the customer test
Metadata
Metadata
Assignees
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressiona: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsdependency: dartDart team may need to help usDart team may need to help us