Skip to content

Customer tests are broken with recent dart analyzer changes #120992

@eyebrowsoffire

Description

@eyebrowsoffire

Rolls from Engine -> Framework have been failing on customer tests coming from https://github.com/rrousselGit/provider.git. See failure here: https://cirrus-ci.com/task/6685374529929216?logs=main#L1826

This is due to changes in the dart sdk that have upgraded some info diagnostics to warning diagnostics: https://dart-review.googlesource.com/c/sdk/+/283400

We need to do the following:

  1. Revert the dart SDK rolls to unblock the engine -> framework roll
  2. Revert the analzyer change so that subsequent dart sdk -> engine rolls don't break downstream
  3. Fix the customer test

Metadata

Metadata

Labels

P0Critical issues such as a build break or regressiona: tests"flutter test", flutter_test, or one of our testsdependency: dartDart team may need to help us

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions