-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stableCherry-picks that should be merged to stablecp: mergedCherry-pick has been merged to the release branch.Cherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queueCherry-picks in the review queue
Description
issue_link
Commit Hash
Target
stable
pr_link
Impacted Users
Using localizations and have unused placeholders in their ARB files
Impact Description
When ARB files other than the template file have fields that are not using the placeholder syntax as the template do, their generated methods won't have the same signature as the template, which will cause invalid overrides that makes the project unable to run.
Workaround
No
Risk
low
Test Coverage
yes
Validation Steps
No response
Metadata
Metadata
Assignees
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stableCherry-picks that should be merged to stablecp: mergedCherry-pick has been merged to the release branch.Cherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queueCherry-picks in the review queue