You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Impeller] Investigate removal of waitUntilScheduled in Metal backend. #120399
changed the title [-][impeller] Investigate removal of waitUntilScheduled in metal backend[/-][+][Impeller] Investigate removal of `waitUntilScheduled` in Metal backend.[/+]on Feb 11, 2023
I added some additional tracing so that we account for the waitUntiLScheduled in the SubmitCommands method. It appears that the vast majority of the time is spent just waiting.
Did you attach the wrong screenshot? That is showing the wait for the next drawable. That is the backpressure mechanism (the GPU telling us we are running ahead of its ability to render the stuff we are telling it to) and this issue isn't describing getting rid of it.
I got rid of the need for this wait as I am wiring up the Vulkan backend and have some notes on how we can do the same for Metal. We can discuss it in the weekly or an OOB sync perhaps?
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
[-][impeller] Investigate removal of waitUntilScheduled in metal backend[/-][+][Impeller] Investigate removal of `waitUntilScheduled` in Metal backend.[/+]jonahwilliams commentedon Mar 11, 2023
I added some additional tracing so that we account for the waitUntiLScheduled in the SubmitCommands method. It appears that the vast majority of the time is spent just waiting.
jonahwilliams commentedon Mar 11, 2023
In the wonderous app, removing
waitUntilScheduledreduces average raster time from 7-8ms down to 1-2ms.chinmaygarde commentedon Mar 11, 2023
Did you attach the wrong screenshot? That is showing the wait for the next drawable. That is the backpressure mechanism (the GPU telling us we are running ahead of its ability to render the stuff we are telling it to) and this issue isn't describing getting rid of it.
I got rid of the need for this wait as I am wiring up the Vulkan backend and have some notes on how we can do the same for Metal. We can discuss it in the weekly or an OOB sync perhaps?
jonahwilliams commentedon Mar 11, 2023
No, take a look at the command buffer upload part. It's all waitUntilScheduled
jonahwilliams commentedon Mar 11, 2023
Weekly sounds fine fyi, just doing some investigating
jonahwilliams commentedon Mar 11, 2023
This is what I added for tracing, I believe it should be accurate.
chinmaygarde commentedon Mar 16, 2023
Note for myself to try to assimilate the ordering guarantees in Metal.
chinmaygarde commentedon Mar 31, 2023
Fixed by @bdero in flutter-team-archive/engine#40781. We were on the wrong lines of investigation w.r.t hazard tracking.
chinmaygarde commentedon Apr 3, 2023
The fix was reverted in flutter-team-archive/engine#40895.
[Impeller] iOS/macOS: Only wait for command scheduling prior to prese…
github-actions commentedon May 10, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[Impeller] iOS/macOS: Only wait for command scheduling prior to prese…