-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stableCherry-picks that should be merged to stablecp: mergedCherry-pick has been merged to the release branch.Cherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queueCherry-picks in the review queue
Description
issue_link
Commit Hash
Target
stable
pr_link
Impacted Users
All flutter web devs that use PathUrlStrategy
Impact Description
The flutter web app won't load if accessed through any path other than /.
Workaround
Yes, there's a workaround that requires messing with the build output files. They basically need to fork the flutter.js file, apply the fix there, and load the forked file instead of the flutter-tool-generated one.
Although the workaround fixes the issue, I don't recommend it because the app won't pick up any future changes that we make in flutter.js, which could lead to mysterious bugs that are hard to track.
Risk
low
Test Coverage
yes
Validation Steps
- Create a sample app.
- Use
PathUrlStrategy. - Load the app at a non-root path (e.g.
http://localhost:xxxxx/a/b/) - The app should load and work.
jorgelrj, davidmigloz, maRci002, ditman, blaneyneil and 13 moremminhlequang and maxmblack
Metadata
Metadata
Assignees
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stableCherry-picks that should be merged to stablecp: mergedCherry-pick has been merged to the release branch.Cherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queueCherry-picks in the review queue