Forbid catchError usage in flutter_tool package #120146
Description
Per #119977 and dart-lang/sdk#51248 using catchError has caused hard-to-track-down runtime crashes when the callback return value is mismatched (even when it "matches" but is more specific) with the future it's called on.
Per #114031 (comment) create a tool test that will fail if catchError is used in the flutter_tools package, and instead suggest then(onError:) be used instead.
An example of a check like this for forbidden imports: