-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/packages
#3100Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.
Description
See flutter/plugins#4803 (comment) for context; originally I thought this was a case where we needed to dynamically generate the function based on specifics of the API, but it turns out that it's always unused (which means I guess I don't have warnings-as-errors turned on for ObjC like I thought I had done; I must be misremembering which languages I've done it for).
GetNullableObject was used when classes were serialized as dictionaries, but now we only use GetNullableObjectAtIndex. The only references to GetNullableObject( anywhere in the generator is where it's generated, so we can just remove it.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.