Skip to content

RawChip doesn't use ChipThemeData.showCheckmark value #119163

@williamhjcho

Description

@williamhjcho

Use case

Hello 👋
While using the new m3 chips, it looks like the RawChip widget itself ignores the showCheckmark from the themes, because its instance value (priority) has a default = true on the constructor.

So whenever I wanted to use a RawChip(...), I would have to RawChip(showCheckmark: null, ...) instead, so it fallbacks to the theme value.

My current flutter version (beta channel)

Flutter 3.7.0-1.4.pre • channel beta • [email protected]:flutter/flutter.git
Framework • revision 686fe913dc (2 weeks ago) • 2023-01-10 16:14:01 -0800
Engine • revision ac5c83dd5f
Tools • Dart 2.19.0 (build 2.19.0-444.4.beta) • DevTools 2.20.0

Proposal

A simple proposal would be removing the default constructor value since the property is already nullable.

Also, ChoiceChip particularly will always override the showCheckmark with the theme.isMaterial3, rather than having it defined on its internal default variation theme.


Not sure if this is better to be a separate issue but I would also love to be able to insert a custom constraint property, either on the theme or instance.

Metadata

Metadata

Assignees

Labels

f: material designflutter/packages/flutter/material repository.found in release: 3.7Found to occur in 3.7frameworkflutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Type

No type

Projects

Status

Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions