Skip to content

[Impeller] src and dst are reversed for advanced blends in FilterContents::MakeBlend Constructor #118903

@jonahwilliams

Description

@jonahwilliams

I would expect that:

ColorFilterContents::MakeBlend(
      blend_mode_,
      {FilterInput::Make(dst_contents), FilterInput::Make(src_contents_)});

Should behave the same with a pipeline blend and an advanced blend. However in flutter/engine#38985 and flutter/engine#38335 I've observed that I actually need to switch the order to match Skia's rendering. This doesn't appear to happen with regular canvas drawing, so we must either be using a different constructor or compensating elsewhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions