-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#38847Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Fluttere: embedderUsers of the Embedder APIUsers of the Embedder APIengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
Description
Use case
Some time ago I implemented configurable pixel formats for the embedder API software rendering backend: flutter/engine#26995
Though what I didn't think about is that the enum values I chose there might be a bit too general, i.e. there's maybe some programs that use kRGBA8888 as identifiers somewhere. (Incidentally, that's the case for my own embedder)
Proposal
Rename the values of the FlutterSoftwarePixelFormat enum and properly namespace them, to avoid name collisions:
kGray8 --> kGray8_FlutterSoftwarePixelFormat
kRGB565 --> kRGB565_FlutterSoftwarePixelFormat
...
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Fluttere: embedderUsers of the Embedder APIUsers of the Embedder APIengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.