Skip to content

[web] Update needed for the updated directory structure in the Dart SDK #118119

New issue
New issue
Closed
#118120
Closed
[web] Update needed for the updated directory structure in the Dart SDK#118119
#118120
Labels
platform-webWeb applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.
@nshahan

Description

@nshahan
nshahan
opened on Jan 6, 2023

For Dart 3.0 I am cleaning up the assets packaged in the Dart SDK for the development web compiler. I'm deleting files that are unused and cleaning up the extraneous sub-directories dart-lang/sdk#50700.

As far as I can tell the only issue this will cause is when require.js is read from the Dart SDK.

flutter/packages/flutter_tools/lib/src/isolated/devfs_web.dart

Lines 929 to 936 in db1c3e2

final File requireJS = globals.fs.file(globals.fs.path.join(
globals.artifacts!.getArtifactPath(Artifact.engineDartSdkPath, platform: TargetPlatform.web_javascript),
'lib',
'dev_compiler',
'kernel',
'amd',
'require.js',
));

The fix will be very simple and I have a PR prepared.
#118120

I'd like guidance in how to land properly or whom to notify since it will break after I land my change in the Dart SDK and it gets rolled into engine, and then into flutter.

A second set of eyes looking at the issue linked above to identify any other potential problems would be helpful as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    platform-webWeb applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions