Remove hard-coded single-view assumption from `ScrollPhysics`

`ScrollPhysics` currently has hard-coded single view assumptions in two places, see the `WidgetsBinding.instance.window` in the snippet below:

https://github.com/flutter/flutter/blob/d1244b7c9b8d676a84bdba2a440ddae1e0907a8c/packages/flutter/lib/src/widgets/scroll_physics.dart#L386-L391

https://github.com/flutter/flutter/blob/d1244b7c9b8d676a84bdba2a440ddae1e0907a8c/packages/flutter/lib/src/widgets/scroll_physics.dart#L249-L258

In a multi-viewed world, this will not work anymore because the `ScrollPhysics` have no idea what view/window the scrollable they control is in. We need to refactor this, i.e. either the ScrollPhysics somehow need to look up the current view via `View.of(context)` or the relevant information need to be passed in.

	static final Tolerance _kDefaultTolerance = Tolerance(
	// TODO(ianh): Handle the case of the device pixel ratio changing.
	// TODO(ianh): Get this from the local MediaQuery not dart:ui's window object.
	velocity: 1.0 / (0.050 * WidgetsBinding.instance.window.devicePixelRatio), // logical pixels per second
	distance: 1.0 / WidgetsBinding.instance.window.devicePixelRatio, // logical pixels
	);

	bool recommendDeferredLoading(double velocity, ScrollMetrics metrics, BuildContext context) {
	assert(velocity != null);
	assert(metrics != null);
	assert(context != null);
	if (parent == null) {
	final double maxPhysicalPixels = WidgetsBinding.instance.window.physicalSize.longestSide;
	return velocity.abs() > maxPhysicalPixels;
	}
	return parent!.recommendDeferredLoading(velocity, metrics, context);
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove hard-coded single-view assumption from `ScrollPhysics` #117478

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Remove hard-coded single-view assumption from ScrollPhysics #117478

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Remove hard-coded single-view assumption from `ScrollPhysics` #117478