Skip to content

Remove hard-coded devicePixelRatio from paintImage #117477

New issue
New issue
Closed
#118721
Closed
Remove hard-coded devicePixelRatio from paintImage#117477
#118721
Assignees
goderbauer
Labels
P1High-priority issues at the top of the work lista: imagesLoading, displaying, rendering imagesframeworkflutter/packages/flutter repository. See also f: labels.
@goderbauer

Description

@goderbauer
goderbauer
opened on Dec 21, 2022

paintImage currently hard-codes the device pixel ratio by reaching out to the window singleton:

flutter/packages/flutter/lib/src/painting/decoration_image.dart

Lines 565 to 567 in d1244b7

// It's ok to use this instead of a MediaQuery because if this changes,
// whatever is aware of the MediaQuery will be repainting the image anyway.
displaySize: outputSize * PaintingBinding.instance.window.devicePixelRatio,

In a multi-viewed world, this will not work anymore because paintImage has no idea what view the image is getting painted on. This will need to be refactored to get the devicePixelRatio passed in.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work lista: imagesLoading, displaying, rendering imagesframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

Multi Window

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions