Skip to content

[CP] Correct sampler order for shaders compiled for MTL/impeller #116921

@jonahwilliams

Description

@jonahwilliams

issue_link

#116610

Commit Hash

3140ad924dc32126b4d07ccfe0b06d0ae9746839

Target

beta

pr_link

flutter/engine#38228

Impacted Users

Impeller/Shaders

Impact Description

Shaders that declare multiple samplers will not work correctly when targeting impeller

Workaround

Conditionally re-order samplers in code based on impeller

Risk

low

Test Coverage

yes

Validation Steps

Run unit tests in PR

Metadata

Metadata

Assignees

No one assigned

    Labels

    cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: reviewCherry-picks in the review queue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions