Skip to content

[Impeller] typo in compiler executable help #116865

@BrianCraig

Description

@BrianCraig

Steps to Reproduce

  1. Execute impellerc

The output should contain

...
[optional] --input-type={comp, frag, tesc, tese, vert, }
...

Actual results:

The output is

...
[optional] --input-kind={comp, frag, tesc, tese, vert, }
...

The actual usage of input-type and not input-kind is here https://github.com/flutter/engine/blob/3140ad924dc32126b4d07ccfe0b06d0ae9746839/impeller/compiler/switches.cc#L101

Flutter doctor -v
bri@bribri:~/repo/shader_toy$ flutter doctor -v
[✓] Flutter (Channel master, 3.7.0-5.0.pre.24, on Ubuntu 22.10 5.19.0-26-generic, locale en_US.UTF-8)
    • Flutter version 3.7.0-5.0.pre.24 on channel master at /home/bri/sdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9fdb64b7e7 (3 hours ago), 2022-12-11 14:43:22 -0800
    • Engine revision 3ca497ebb1
    • Dart version 3.0.0 (build 3.0.0-12.0.dev)
    • DevTools version 2.20.0

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /home/bri/Android/Sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: /home/bri/app/android-studio/jre/bin/java
    • Java version Java(TM) SE Runtime Environment (build 17.0.1+12-LTS-39)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 15.0.2-1
    • cmake version 3.24.2
    • ninja version 1.11.0
    • pkg-config version 0.29.2

[✓] Android Studio (version 2021.2)
    • Android Studio at /home/bri/app/android-studio
    • Flutter plugin version 70.2.2
    • Dart plugin version 212.5744
    • Java version Java(TM) SE Runtime Environment (build 17.0.1+12-LTS-39)

[✓] VS Code (version 1.72.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.54.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Ubuntu 22.10 5.19.0-26-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.87

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer version

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions