Skip to content

"do not use namespace using-directives; use using-declarations instead" google-build-using-namespace warnings #115521

@jmagman

Description

@jmagman
❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/shell/platform/linux/testing/mock_binary_messenger.cc:
/b/s/w/ir/cache/builder/src/flutter/shell/platform/linux/testing/mock_binary_messenger.cc:8:1: error: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace,-warnings-as-errors]
using namespace flutter::testing;
^

❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/shell/platform/linux/testing/mock_settings.cc:
/b/s/w/ir/cache/builder/src/flutter/shell/platform/linux/testing/mock_settings.cc:7:1: error: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace,-warnings-as-errors]
using namespace flutter::testing;
^

❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/shell/platform/linux/testing/mock_text_input_view_delegate.cc:
/b/s/w/ir/cache/builder/src/flutter/shell/platform/linux/testing/mock_text_input_view_delegate.cc:7:1: error: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace,-warnings-as-errors]
using namespace flutter::testing;
^

❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/shell/platform/linux/testing/mock_im_context.cc:
/b/s/w/ir/cache/builder/src/flutter/shell/platform/linux/testing/mock_im_context.cc:7:1: error: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace,-warnings-as-errors]
using namespace flutter::testing;
^

etc

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8797288801511583249/+/u/test:_lint_host_debug/stdout
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8797288801518646705/+/u/test:_lint_host_debug/stdout
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8797288801518646689/+/u/test:_lint_ios_debug_sim/stdout

https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/google-build-using-namespace.html

See flutter/engine#37698

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions