Skip to content

"C-style casts are discouraged" google-readability-casting warnings #115518

@jmagman

Description

@jmagman

On Linux host

❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/flow/layers/backdrop_filter_layer.cc:
/b/s/w/ir/cache/builder/src/flutter/flow/layers/backdrop_filter_layer.cc:45:63: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
      Layer::AutoPrerollSaveLayerState::Create(context, true, bool(filter_));

❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/gles/shader_library_gles.cc:
/b/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/gles/shader_library_gles.cc:67:45: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
    functions[ShaderKey{key_name, stage}] = std::shared_ptr<ShaderFunctionGLES>(

❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/vulkan/shader_library_vk.cc:
/b/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/vulkan/shader_library_vk.cc:88:45: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
    functions[ShaderKey{key_name, stage}] = std::shared_ptr<ShaderFunctionVK>(

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8797288801511583249/+/u/test:_lint_host_debug/stdout

See also flutter/engine#36885

cc @gaaclarke

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions