Skip to content

i10n_gen errors/warnings improvement suggestions + need testing #115501

@zanderso

Description

@zanderso

After the change here: #112390, building the new Flutter gallery for iOS fails at tip-of-tree. [eta: the build failure was a different issue, filed a separate issue.]

I see some issues with #112390.

  1. Lots of commented out code. If a fast-follow had been landed as @HansMuller mentioned, then that would have been okay, but it's been 11 days or so.
  2. I'm not seeing a test for this particular error path: The plural part....
  3. The tests that do exist, don't seem to be testing that the second two lines of the error message print something useful.
  4. The second part of the message is coming through empty for me, and the third part, which is supposed to have the file and line number are empty, so I can't track down the issue with flutter/gallery.
  5. nit: As mentioned on the PR, "overrided" should be "overridden".

cc @thkim1011 @HansMuller @christopherfujino

There's a separate issue, which seems to be that the new Xcode error handling code seems to treat printWarnings from i10n_gen as fatal, both with and without #112390. cc @jmagman

Metadata

Metadata

Assignees

Labels

toolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions