-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
After the change here: #112390, building the new Flutter gallery for iOS fails at tip-of-tree. [eta: the build failure was a different issue, filed a separate issue.]
I see some issues with #112390.
- Lots of commented out code. If a fast-follow had been landed as @HansMuller mentioned, then that would have been okay, but it's been 11 days or so.
- I'm not seeing a test for this particular error path:
The plural part.... - The tests that do exist, don't seem to be testing that the second two lines of the error message print something useful.
- The second part of the message is coming through empty for me, and the third part, which is supposed to have the file and line number are empty, so I can't track down the issue with flutter/gallery.
- nit: As mentioned on the PR, "overrided" should be "overridden".
cc @thkim1011 @HansMuller @christopherfujino
There's a separate issue, which seems to be that the new Xcode error handling code seems to treat printWarnings from i10n_gen as fatal, both with and without #112390. cc @jmagman
Metadata
Metadata
Assignees
Labels
toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.