Skip to content

PlatformViews need clipRect. #114784

@endless7

Description

@endless7

Hi, when using platformviews, getLocalClipBounds should return the bounds of the platformview, not the bounds of the canvas.

// SkBigPicture.cpp
const bool useBBH = !canvas->getLocalClipBounds().contains(this->cullRect());

When I did clipRect as below, it became correct.

SkCanvas* overlay_canvas = frame->SkiaCanvas();
overlay_canvas->clipRect(rect);

flutter/engine#37107

cc @ColdPaleLight @flar @dnfield

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecta: platform-viewsEmbedding Android/iOS views in Flutter appsengineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions