Skip to content

[CP] Make ImpellerC handle unicode characters in paths #111689

@dnfield

Description

@dnfield

issue_link

#107590

Commit Hash

b6f4f8dd4a5647d0c6da39fce85ff380218a1d1f

Target

stable

pr_link

flutter/engine#36158

Impacted Users

Flutter devs who have non-ASCII characters in project paths

Impact Description

Tool crashes on building Flutter projects.

Workaround

Rename directory to not contain unicode characters.

Risk

low

Test Coverage

no

Validation Steps

We are working on automated tests for this (e.g. including unicode characters in testing done on CI).

To validate, on a Windows machine, introduce a unicode character into the project path and try to run flutter run -d windows.

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions