[file_selector] Add iOS's implementations for getDirectoryPath and getSavePath

Use case

The current implementation of the file_selector plugin has missing features on iOS.

There are other packages available that offer this implementation that can be used as guidance.

Proposal

Add the missing implementations to satisfy the whole interface.

One of your pictures is of the test page for getSavePath. Can you elaborate on what you expect that method to do on iOS?

Hi Stuart, thanks for your prompt response. About the second image, I would expect that the plugin let users select a directory, like it does on the other platforms.

Here is the code that is being invoked on this page:

Future<String?> getDirectoryPath({
  String? initialDirectory,
  String? confirmButtonText,
}) async {
  return FileSelectorPlatform.instance.getDirectoryPath(
      initialDirectory: initialDirectory, confirmButtonText: confirmButtonText);
}

Thanks,

About the second image, I would expect that the plugin let users select a directory

Yes, but that's getDirectoryPath; I was asking about getSavePath.

Hi Stuart, we just want to share the same functionality among all the platforms. We've already verified that the XFile abstraction allows developers to store a file in the device.

Thanks,

we just want to share the same functionality among all the platforms

I understand that, but we're wrapping OS functionality in file_selector. What is the iOS version of a save dialog that you are proposing wrapping with getSavePath?

We've already verified that the XFile abstraction allows developers to store a file in the device.

XFile is an abstraction around files; file_selector is an abstraction around native file selector UI. They are very different layers. getSavePath doesn't save anything, it shows UI that allows someone to choose where to save something. I'm trying to understand what you are proposing that UI be on iOS.

Hi, please correct me if I'm wrong but, I would propose opening the file selector just to pick a folder, pretty similar to what getDirectoryPath will do.

Thanks,

getSavePath returns a file, not a directory, so that would have the wrong semantics.

I'm not aware of any iOS analog to a save dialog, and it sounds like you aren't either, so I'm still not clear on why you believe that the lack of implementation of getSavePath is a bug.

Hi Stuart,
Thanks for the clarification, now I have a better understanding of your concern. We explored other packages and found inspiration in this one called flutter_file_dialog. It allows users to select a folder where the file is going to be saved.

The current code of the flutter_file_dialog doesn't match one-to-one with the file_selector implementation but, it offers a great starting point for developers.

What do you think of offering a UI like this one?

I'm not clear on what that UI is exactly. What component is that displaying?

Hi Stuart,
It is relying on an UIDocumentPickerViewController.

@huycozy

Hi @huycozy, that's correct. Thanks!

Navigation Menu

Repository navigation

[file_selector] Add iOS's implementations for getDirectoryPath and getSavePath #111583

Use case

Proposal

3 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[file_selector] Add iOS's implementations for getDirectoryPath and getSavePath #111583

Description

Use case

Proposal

Activity

stuartmorgan-g commented on Sep 14, 2022

juandausa commented on Sep 15, 2022

stuartmorgan-g commented on Sep 15, 2022

juandausa commented on Sep 15, 2022

stuartmorgan-g commented on Sep 15, 2022

juandausa commented on Sep 16, 2022

stuartmorgan-g commented on Sep 16, 2022

juandausa commented on Sep 21, 2022

stuartmorgan-g commented on Sep 21, 2022

juandausa commented on Sep 21, 2022

3 remaining items

juandausa commented on Sep 27, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions