-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/packages
#3393Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.p: toolingAffects the flutter_plugin_tools packageAffects the flutter_plugin_tools packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.
Description
make-deps-path-based will add dependency overrides to anything with a direct dependency on a package, but in some cases examples only have transitive dependencies on some of the changed packages (e.g., the app-facing example doesn't generally have direct dependencies on the implementation packages), and since dependency overrides don't have any transitive effect the results of running the command will not work for all tests.
We should have the command clone any dependency overrides it adds to foo/pubspec.yaml to foo/example/**/pubspec.yaml.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.p: toolingAffects the flutter_plugin_tools packageAffects the flutter_plugin_tools packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.