Skip to content

Dart -> Engine roll failing on analyzer breaking changes #110670

@zanderso

Description

@zanderso

Starting in flutter/engine#35827

For example the build https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Host%20Engine/42313/overview

lib/apicheck.dart:39:54: Error: The getter 'name' isn't defined for the class 'ClassDeclaration'.
 - 'ClassDeclaration' is from 'package:analyzer/dart/ast/ast.dart' ('../../../third_party/dart/pkg/analyzer/lib/dart/ast/ast.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'name'.
    if (unitMember is ClassDeclaration && unitMember.name.name == className) { // ignore: deprecated_member_use
                                                     ^^^^
lib/apicheck.dart:43:44: Error: The getter 'name' isn't defined for the class 'VariableDeclaration'.
 - 'VariableDeclaration' is from 'package:analyzer/dart/ast/ast.dart' ('../../../third_party/dart/pkg/analyzer/lib/dart/ast/ast.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'name'.
            final String fieldName = field.name.name; // ignore: deprecated_member_use
                                           ^^^^


!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!


Failed Command:

/opt/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/bin/dart --disable-dart-dev /opt/s/w/ir/cache/builder/src/flutter/tools/api_check/test/apicheck_test.dart /opt/s/w/ir/cache/builder/src/flutter

Looks like it is maybe: https://dart.googlesource.com/sdk.git/+/d8df88cbe41457af0c5de4875ba428a72d66c78f

cc @a-siva @scheglov @bwilkerson

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressiondependency: dartDart team may need to help us

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions