-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick request
Description
issue_link
Commit Hash
Target
beta
pr_link
Impacted Users
Flutter devs targeting android who have malformed XML config files, such as their manifest
Impact Description
When the tool fails to parse a malformed XML config file, rather than showing a user friendly tool exit with the absolute path to the file that the user must fix, the exception will bubble up and the user will have to check the source code to determine what the tool was trying to parse.
Workaround
The user would have to know to check their app's manifest file.
Risk
low
Test Coverage
yes
Validation Steps
- Create a new flutter app:
flutter create test_bad_xml - edit the contents of
test_bad_xml/android/app/src/debug/AndroidManifest.xmlto have invalid XML, such as<manifest></application> - build the app in debug mode:
flutter build apk --debug; verify that there is a tool exit with the path to the bad file.
Metadata
Metadata
Assignees
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick request