Skip to content

Update python3 references to vpython3 #108474

Open

Description

@a-wallen

TL;DR

Update python3 references with vpython3 for consistent, reproducible builds.

Root cause

Instructions for setting up the Engine development environment guide users to install both Chromium's depot_tools and Python.

  • Chromium's depot_tools (make sure it's in your path). We use the gclient tool from depot_tools.
    Make sure to install gclient by running ./gclient in the command line.
  • Python (used by many of our tools, including gclient).

Hence, developers correctly assume that they may rely on python3 when developing scripts, but a user installed python3 can lead to unexpected behavior as seen in #108122 and confusion.

The history shows that we intended to use vpython3 for consistent, reproducible builds, but due the following upstream issue, #88719, those references were reverted back to python3.

WIP Todo List:

  1. Update python3 references to vpython3
  1. Update Setting up the Engine development environment

Activity

  1. added
    engineflutter/engine related. See also e: labels.
    team-infraOwned by Infrastructure team
    on Jul 27, 2022
  2. loic-sharma commented on Jul 29, 2022

    @loic-sharma
    Member

    To catch unexpected uses of python3, consider putting a python3 script at the front of your path that fails loudly. You'll want to make sure the dev workflow still works as expected, including build, git push (for git hooks), etc...

  3. added
    P2Important issues not at the top of the work list
    on Aug 1, 2022
  4. flutter-triage-bot commented on Jul 8, 2023

    @flutter-triage-bot

    Issue is assigned to multiple teams (infra, engine). Please ensure the issue has only one team-* label at a time. Use fyi-* labels to have another team look at the issue without reassigning it.
    The triaged-engine label is irrelevant if there is no team-engine label or fyi-engine label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions