Skip to content

//third-party/abseil-cpp emitting warnings #108388

@cbracken

Description

@cbracken

On Windows, I'm seeing a lot of warnings due to -Wdeprecated-builtins (and possibly others) in //third_party/abseil-cpp. It doesn't appear that we've rolled ANGLE anytime recently, so it's possible these were triggered by a new #include of abseil in our own code, or a third-party dependency (libangle uses it and rolled on 2022-06-23.

We should probably try to roll abseil to tip of tree (it looks like it hasn't rolled in a couple years), and see if that resolves it. If not, then we should tweak our build config to add -Wno-deprecated-builtins until the warning is fixed upstream.

/cc @dnfield @jason-simmons in case they're aware of whether this was due to the angle roll and since @jason-simmons filed a bug to create a mirror of abseil-cpp recently.

In file included from ../../third_party/abseil-cpp\absl/algorithm/container.h:55:
../../third_party/abseil-cpp\absl/meta/type_traits.h(293,36): warning: builtin __has_trivial_destructor is deprecated; use __is_trivially_destructible instead [-Wdeprecated-builtins]
    : std::integral_constant<bool, __has_trivial_destructor(T) &&
                                   ^
../../third_party/abseil-cpp\absl/meta/type_traits.h(342,36): warning: builtin __has_trivial_constructor is deprecated; use __is_trivially_constructible instead [-Wdeprecated-builtins]
    : std::integral_constant<bool, __has_trivial_constructor(T) &&
                                   ^
../../third_party/abseil-cpp\absl/meta/type_traits.h(486,17): warning: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Wdeprecated-builtins]
          bool, __has_trivial_assign(typename std::remove_reference<T>::type) &&
                ^
../../third_party/abseil-cpp\absl/meta/type_traits.h(530,8): warning: builtin __has_trivial_copy is deprecated; use __is_trivially_constructible instead [-Wdeprecated-builtins]
      (__has_trivial_copy(ExtentsRemoved) || !kIsCopyOrMoveConstructible) &&
       ^
../../third_party/abseil-cpp\absl/meta/type_traits.h(531,8): warning: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Wdeprecated-builtins]
      (__has_trivial_assign(ExtentsRemoved) || !kIsCopyOrMoveAssignable) &&
       ^
../../third_party/abseil-cpp\absl/meta/type_traits.h(293,36): warning: builtin __has_trivial_destructor is deprecated; use __is_trivially_destructible instead [-Wdeprecated-builtins]
    : std::integral_constant<bool, __has_trivial_destructor(T) &&
                                   ^
../../third_party/abseil-cpp\absl/meta/type_traits.h(91,27): note: in instantiation of template class 'absl::is_trivially_destructible<std::basic_string_view<char>>' requested here
                    absl::is_trivially_destructible<T>::value> {};
                          ^
../../third_party/abseil-cpp\absl/meta/type_traits.h(414,41): note: in instantiation of template class 'absl::type_traits_internal::IsTriviallyCopyConstructibleObject<std::basic_string_view<char>>' requested here
          std::is_lvalue_reference<T>>::type::type {
                                        ^
../../third_party/abseil-cpp\absl/functional/internal/function_ref.h(46,16): note: in instantiation of template class 'absl::is_trivially_copy_constructible<std::basic_string_view<char>>' requested here
         absl::is_trivially_copy_constructible<T>::value &&
               ^
../../third_party/abseil-cpp\absl/functional/internal/function_ref.h(54,36): note: in instantiation of function template specialization 'absl::functional_internal::PassByValue<std::basic_string_view<char>>' requested here
struct ForwardT : std::conditional<PassByValue<T>(), T, T&&> {};
                                   ^
../../third_party/abseil-cpp\absl/functional/internal/function_ref.h(63,1): note: in instantiation of template class 'absl::functional_internal::ForwardT<std::basic_string_view<char>>' requested here
using Invoker = R (*)(VoidPtr, typename ForwardT<Args>::type...);
^
../../third_party/abseil-cpp\absl/functional/function_ref.h(133,30): note: in instantiation of template type alias 'Invoker' requested here
  absl::functional_internal::Invoker<R, Args...> invoker_;
                             ^
../../third_party/abseil-cpp\absl/strings/cord.h(1225,48): note: in instantiation of template class 'absl::FunctionRef<void (std::basic_string_view<char>)>' requested here
    absl::FunctionRef<void(absl::string_view)> callback) const {

Metadata

Metadata

Assignees

No one assigned

    Labels

    engineflutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specifically

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions