Skip to content

FfiNative PictureRecorder::endRecording wrong return type #108309

@dcharkes

Description

@dcharkes
  @FfiNative<Handle Function(Pointer<Void>, Handle)>('PictureRecorder::endRecording')
  external void _endRecording(Picture outPicture);

https://github.com/flutter/engine/blob/main/lib/ui/painting.dart#L5664-L5665

Either the Dart return type should be Object or the native return type should be Void.

cc @dnfield, landing the static checks found another issue.

I'll revert the added checks in Dart for now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions