-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterf: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
The SliverDecoration widget introduced in PR #107269 is not finished and has at least the following issues:
- It doesnt work in horizontal scrollviews
- It uses the paintExtent of the child which isn't always the correct value to use, take for instance this example when applying a rounde corner. The bottom two corners shouldn't be rounded yet.
- Overlap and other advanced properties of slivers aren't accounted for.
- The name is inconsistent with the box counterpart
DecoratedBox, this should be calledDecoratedSliver. The current name suggests its the configuration just likeBoxDecoration
The correct behaviour should be the same as using a SliverStack from sliver_tools with a SliverPositioned.fill behind the second child sliver.
Minimal repro example I can add later if needed (dont have time right now).
Proposed resolution steps
- Revert [framework] SliverDecoration #107269 ✅
- Discuss here what sliver features the finished implementation should and shouldnt support
- Create extensive widget tests for those cases and reimplement
himamis, spydon, AlpSha, ElenaRepeatMD and MendleM
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterf: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Type
Projects
Status
Done
