-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.perf: memoryPerformance issues related to memoryPerformance issues related to memoryperf: speedPerformance issues related to (mostly rendering) speedPerformance issues related to (mostly rendering) speed
Description
At https://flutter-flutter-perf.skia.org/t/, I have left untriaged the benchmark changes that SkiaPerf has flagged on the engine roll #106848, which contains only flutter/engine#31892.
It looks like cache usage has generally gone up, some raster times have gone up, and some raster times have gone down. Unfortunately, I don't have enough context to know whether these trade-offs are expected or reasonable.
Since we are going to cut a beta branch soon, I'm filing this issue to prioritize triaging these flags after the holiday weekend.
Metadata
Metadata
Assignees
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.perf: memoryPerformance issues related to memoryPerformance issues related to memoryperf: speedPerformance issues related to (mostly rendering) speedPerformance issues related to (mostly rendering) speed