Skip to content

[CP] Ignore invalid description in vswhere.exe JSON output #106920

@loic-sharma

Description

@loic-sharma

issue_link

#106601

Commit Hash

dcbdff0

Target

stable

Impacted Users

Windows developers using specific locales

Impact Description

This impacts development: flutter doctor, flutter run, and flutter build do not work on Windows for certain locales.

Only Chinese and Japanese locales are known to be affected by this issue. However, it is likely that other locales are also affected by this.

Workaround

Yes, workarounds include:

  1. Downgrade Visual Studio to an unaffected version
  2. Switch your locale to English
  3. Patch your Visual Studio installation and replace vswhere.exe with an unreleased build: https://github.com/microsoft/vswhere/releases

Risk

low

Test Coverage

yes

Validation Steps

This fix is covered by unit tests. It can also be verified manually by running flutter doctor on Windows.

Metadata

Metadata

Assignees

No one assigned

    Labels

    cp: approvedApproved cherry-pick request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions