Skip to content

[pigeon] C++ generated FlutterError and ErrorOr violate style #106438

Closed
flutter/packages
#2349

Description

@stuartmorgan-g

FlutterError has public member variables, rather than private + getters. ErrorOr names its private field v instead of v_, and defines hasError instead of has_error or HasError.

Activity

  1. added
    platform-windowsBuilding on or for Windows specifically
    packageflutter/packages repository. See also p: labels.
    p: pigeonrelated to pigeon messaging codegen tool
    P1High-priority issues at the top of the work list
    on Jun 22, 2022
  2. github-actions commented on Aug 4, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  3. locked as resolved and limited conversation to collaborators on Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P1High-priority issues at the top of the work listp: pigeonrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.platform-windowsBuilding on or for Windows specifically

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions