Skip to content

Engine Tree red due to change in API while PR was in-progress #106218

@iskakaushik

Description

@iskakaushik

PR: flutter/engine#34024

../../flutter/impeller/display_list/display_list_unittests.cc:326:13: error: no matching member function for call to 'drawImage'
    builder.drawImage(DlImageImpeller::Make(texture), SkPoint::Make(200, 200),
    ~~~~~~~~^~~~~~~~~
../../flutter/display_list/display_list_builder.h:274:8: note: candidate function not viable: no known conversion from 'SkSamplingOptions' to 'flutter::DlImageSampling' for 3rd argument
  void drawImage(const sk_sp<DlImage> image,
       ^
../../flutter/display_list/display_list_builder.h:278:8: note: candidate function not viable: no known conversion from 'SkSamplingOptions' to 'flutter::DlImageSampling' for 3rd argument
  void drawImage(const sk_sp<DlImage> image,

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8811082473885209041/+/u/build_host_release/stdout

@JsouLiang could you please rebase and create a new PR? I'm going to revert the old one.

cc: @flar

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressionengineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions