-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listteam-infraOwned by Infrastructure teamOwned by Infrastructure team
Description
It seems that the new autosubmit bot is not closing the related issues/PRs of the PRs it merges, for example:
- Merged PR: [web] Fix JS crash when FF blocks service workers. #106072
- Didn't close: [Flutter 3] Web app fails to load in firefox if "Delete cookies and site data when Firefox is closed" is checked in settings #103972
Another example:
- Merged PR: [video_player] Fix disposed VideoPlayerController throwing an error when calling dispose() again plugins#5952
- Didn't close: [video_player] Calling dispose() twice on the same VideoPlayerController throws an exception #104062
In both cases, I had linked the PR to the Issue before it was merged by the bot (with Github's keyword syntax), but in neither case the auto-submit bot closed the related Issue/PR.
The previous auto-merge bot used to do this, for example:
- Merged PR: [url_launcher] Fixes call to setState after dispose. plugins#5963
- Automatically closed: [url_launcher]Error: setState() called after dispose(): _PlatformViewLinkState#946fb(lifecycle state: defunct, not mounted) #102741 and [url_launcher] Fixed call to onPlatformViewCreated after dispose plugins#5431
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listteam-infraOwned by Infrastructure teamOwned by Infrastructure team