-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterf: inspectorPart of widget inspector in framework.Part of widget inspector in framework.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
Currently setPubRootDirectories replaces the entire set of pubRoot Directories. So the caller can run into race conditions where another caller has changed the pubroot directories, since the last time getPubRootDirectories were called.
To allow for more flexible and safe interaction with pubRootDirectories, change the API to have addPubRootDirectories(List<String>) and removePubRootDirectories(List<String>).
Then change setPubRootDirectories so that it actually wraps addPubRootDirectories and add a deprecation notice to the function
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterf: inspectorPart of widget inspector in framework.Part of widget inspector in framework.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.