-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listfound in release: 3.0Found to occur in 3.0Found to occur in 3.0found in release: 3.1Found to occur in 3.1Found to occur in 3.1has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onplatform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specificallyr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versiontoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
Seen behavior
lib\hello_bindings_generated.dart contains no bindings.
Expected behavior
lib\hello_bindings_generated.dart contains bindings for sum and sum_long_running.
Steps to reproduce
On Windows:
flutter create --template plugin_ffi hellocd helloflutter pub run ffigen --config ffigen.yaml
Root cause
Path separator on Windows not converted to backslash:
Fix
Bump package:ffigen to a new version after landing:
Testing
We should possibly also add a test exercising the run of the bindings generator on the bots, but this requires having libclang available.
On the package:ffigen bots we use GitHub workflows.
- name: Install libclang-10-dev
run: sudo apt-get install libclang-10-dev@stuartmorgan Do we have libclang on the Flutter bots? Can we have this on the bots?
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listfound in release: 3.0Found to occur in 3.0Found to occur in 3.0found in release: 3.1Found to occur in 3.1Found to occur in 3.1has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onplatform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specificallyr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versiontoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.