-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.
Description
Pigeon doesn't depend on Flutter but it is listed as a dependency in the pubspec.yaml. This causes 2 problems:
- On new versions of flutter it causes
run_tests.shto fail since it usesdartto run tests, but the tests will error out saying you need to runflutterinstead - The pub.dev page says it is "unidentified" since it doesn't list any platforms
Our options are to:
- Fully embrace the dependency on flutter despite the fact there is no actual runtime dependency on flutter
- Rip out the dependency on flutter
Ripping it out is technically correct but if we do that it will confuse different ci steps that rely on that dependency to be there. Maybe it is a good idea to fully embrace the dependency on flutter in order to control access to new flutter features. In the past we've just always conformed to the platform channel API which is pretty stable so no version check of flutter was necessary.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.